Skip to content

AF calendar-adapter estimator + measurement families (supersedes #89)#92

Merged
hmgaudecker merged 1 commit into
mainfrom
af-estimator-pr
Jun 30, 2026
Merged

AF calendar-adapter estimator + measurement families (supersedes #89)#92
hmgaudecker merged 1 commit into
mainfrom
af-estimator-pr

Conversation

@hmgaudecker

Copy link
Copy Markdown
Member

#89 merged a mistaken, earlier state of the AF/AMN work. This brings main up to the correct current state.

Scope (delta over #89):

  • AF source/destination calendar adapter: compiled step layout/data/assembly (step_layout.py, step_data.py, step_assembly.py) with the contemporaneous investment calendar.
  • Public measurement-family interface on ModelSpec (measurement_models) + shared measurement log-likelihood kernel.
  • AFEstimationOptions.bounds_distance (SD floor; AF Monte Carlo uses 0.01).
  • Limited-measurement handling, sequential-criterion rename, posterior-state/inference migration onto the compiled layout, plus guards, tests, and docs.

Single squashed commit on top of origin/main; CI will validate.

🤖 Generated with Claude Code

…state)

#89 merged a mistaken, earlier snapshot of the AF/AMN work. This brings main
up to the correct current state:

- AF source/destination calendar adapter: compiled step layout/data/assembly
  (step_layout.py, step_data.py, step_assembly.py) with the contemporaneous
  investment calendar, replacing the ad-hoc per-period assembly.
- Public measurement-family interface on ModelSpec (measurement_models) and a
  shared measurement log-likelihood kernel.
- AFEstimationOptions.bounds_distance to set the SD floor (AF MC uses 0.01).
- Limited-measurement handling, sequential-criterion rename, posterior-state
  and inference migration onto the compiled layout, plus guards and docs.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.05668% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.82%. Comparing base (014c36a) to head (77acc77).

Files with missing lines Patch % Lines
src/skillmodels/common/simulate_data.py 76.47% 8 Missing ⚠️
src/skillmodels/af/transition_period.py 95.65% 4 Missing ⚠️
src/skillmodels/af/posterior_states.py 80.00% 3 Missing ⚠️
src/skillmodels/common/model_spec.py 91.42% 3 Missing ⚠️
src/skillmodels/af/step_data.py 93.33% 2 Missing ⚠️
tests/test_af_step_compile.py 94.11% 2 Missing ⚠️
src/skillmodels/af/step_assembly.py 98.33% 1 Missing ⚠️
tests/test_constraints.py 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   95.61%   95.82%   +0.21%     
==========================================
  Files         123      142      +19     
  Lines       12947    14122    +1175     
==========================================
+ Hits        12379    13533    +1154     
- Misses        568      589      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmgaudecker hmgaudecker merged commit 4471d40 into main Jun 30, 2026
6 checks passed
@hmgaudecker hmgaudecker deleted the af-estimator-pr branch June 30, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant